lasdf1234 commented on code in PR #11209:
URL: https://github.com/apache/gravitino/pull/11209#discussion_r3296704811
##########
plugins/idp-basic/src/main/java/org/apache/gravitino/idp/storage/service/IdpGroupMetaService.java:
##########
@@ -70,7 +70,12 @@ public void insertIdpGroup(IdpGroupPO groupPO) {
@Monitored(
metricsSource = GRAVITINO_RELATIONAL_STORE_METRIC_NAME,
baseMetricName = "deleteIdpGroup")
- public boolean deleteIdpGroup(String groupName) {
+ public boolean deleteIdpGroup(String groupName, boolean cascade) {
Review Comment:
Got "Force" has a clearer and more straightforward meaning compared to
"cascade".It would be best to change it to "force". The code has been modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
