roryqi commented on code in PR #11226:
URL: https://github.com/apache/gravitino/pull/11226#discussion_r3311428023


##########
plugins/idp-basic/src/main/java/org/apache/gravitino/idp/IdpUserGroupManager.java:
##########
@@ -64,7 +96,39 @@ public IdpUserGroupManager(Config config, IdGenerator 
idGenerator) {
     this.idGenerator = idGenerator;
     this.passwordHasher = PasswordHasherFactory.create();
     this.garbageCollector = new IdpGarbageCollector(config);
-    garbageCollector.start();
+    this.garbageCollector.start();
+  }
+
+  public void initializeConfiguredServiceAdmins(Config config, String 
initialAdminPassword)
+      throws IOException {
+    List<String> serviceAdmins = config.get(Configs.SERVICE_ADMINS);
+    if (serviceAdmins == null || serviceAdmins.isEmpty()) {

Review Comment:
   StringUtils.isNotBlank?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to