roryqi commented on code in PR #11226:
URL: https://github.com/apache/gravitino/pull/11226#discussion_r3311610599
##########
plugins/idp-basic/src/main/java/org/apache/gravitino/idp/storage/po/IdpUserWithGroupsPO.java:
##########
@@ -16,22 +16,27 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.gravitino.idp.web.rest.feature;
+package org.apache.gravitino.idp.storage.po;
-import static org.junit.jupiter.api.Assertions.assertFalse;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import lombok.AccessLevel;
+import lombok.AllArgsConstructor;
+import lombok.Builder;
+import lombok.EqualsAndHashCode;
+import lombok.Getter;
+import lombok.NoArgsConstructor;
+import lombok.ToString;
-import java.util.List;
-import org.junit.jupiter.api.Test;
-
-class TestIdpRESTFeature {
-
- @Test
- void testBasicAuthenticatorEnabled() {
- assertFalse(IdpRESTFeature.basicAuthenticatorEnabled(null));
- assertFalse(IdpRESTFeature.basicAuthenticatorEnabled(List.of("simple")));
- assertTrue(
- IdpRESTFeature.basicAuthenticatorEnabled(
- List.of("simple", IdpRESTFeature.BASIC_AUTHENTICATOR)));
- }
+/**
+ * Read-only PO for built-in IdP user rows joined with aggregated group names.
This PO is not
+ * written to the database.
+ */
+@Getter
+@EqualsAndHashCode
+@ToString
+@NoArgsConstructor(access = AccessLevel.PRIVATE)
+@AllArgsConstructor(access = AccessLevel.PRIVATE)
+@Builder(setterPrefix = "with")
+public class IdpUserWithGroupsPO {
Review Comment:
Could u reuse old userGroupPO?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
