Copilot commented on code in PR #11344:
URL: https://github.com/apache/gravitino/pull/11344#discussion_r3339154827
##########
web/web/src/app/rootLayout/Layout.js:
##########
@@ -79,12 +79,14 @@ const Layout = ({ children, scrollToTop }) => {
<Box sx={{ flex: 1 }}>
<Typography variant='body2' component='div'>
<Box component='span' sx={{ fontWeight: 600 }}>
- Try the new V2 Web UI.
+ Try to use the V2 Web UI.
Review Comment:
The phrasing "Try to use the V2 Web UI." reads awkwardly compared to the
previous "Try the new V2 Web UI." Since this banner is shown in the V1 UI to
encourage users to switch, consider keeping the more natural call-to-action
wording, e.g. "Try the V2 Web UI."
##########
docs/webui-v2.md:
##########
@@ -14,11 +14,11 @@ This document outlines how users can manage metadata within
Apache Gravitino usi
## UI Version 1.2.0 — Web V2 introduced
-Starting with version 1.2.0, Gravitino introduces Web V2. By default, the
template does not set `GRAVITINO_USE_WEB_V2`, so the container or environment
controls which UI is used. To force the v1 UI, explicitly set it to `false`; to
enable the v2 UI, set it to `true` (for example: `export
GRAVITINO_USE_WEB_V2=true`). If you want to enable Web V2 from the server env
file, set the following environment variable in `conf/gravitino-env.sh` before
starting the server:
+Starting with version 1.2.0, Gravitino introduces Web V2. By default, leave
`GRAVITINO_USE_WEB_V1` unset (or set it to `false`) to use Web V2. Set
`GRAVITINO_USE_WEB_V1=true` only when you want to force Web V1. If you want to
force Web V1 from the server env file, set the following environment variable
in `conf/gravitino-env.sh` before starting the server:
Review Comment:
This sentence is redundant: it already says "Set `GRAVITINO_USE_WEB_V1=true`
only when you want to force Web V1" immediately before, then repeats "If you
want to force Web V1 from the server env file...". Consider tightening to a
single instruction, e.g. "To force Web V1, set the following environment
variable in `conf/gravitino-env.sh` before starting the server:".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
