jerryshao commented on code in PR #11344: URL: https://github.com/apache/gravitino/pull/11344#discussion_r3353900122
########## conf/gravitino-env.sh.template: ########## @@ -33,6 +33,6 @@ GRAVITINO_VERSION=GRAVITINO_VERSION_PLACEHOLDER # # Appended to JAVA_OPTS by launch scripts; set GRAVITINO_MEM to change heap/metaspace sizes. # UI selection behaviour: -# - By default this template does not set `GRAVITINO_USE_WEB_V2`, so the container or environment can control which UI is used. -# - To force the v1 UI, explicitly set it to `false`; to enable the v2 UI, set it to `true` (for example: `export GRAVITINO_USE_WEB_V2=true`). -# GRAVITINO_USE_WEB_V2=false \ No newline at end of file +# - Leave `GRAVITINO_USE_WEB_V1` unset, or set it to `false`, to use the v2 UI. +# - Set `GRAVITINO_USE_WEB_V1=true` only when you want to force the v1 UI. +# GRAVITINO_USE_WEB_V1=false Review Comment: Removing `GRAVITINO_USE_WEB_V2` and introducing a new `GRAVITINO_USE_WEB_V1` will break the compatibility if the user already uses `GRAVITINO_USE_WEB_V2`. I think we make `GRAVITINO_USE_WEB_V2` to `true` as a default value, no need to introduce a new `GRAVITINO_USE_WEB_V1` env variable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
