mchades commented on code in PR #11264:
URL: https://github.com/apache/gravitino/pull/11264#discussion_r3377536696
##########
api/src/main/java/org/apache/gravitino/credential/JdbcCredential.java:
##########
@@ -107,8 +107,7 @@ public String toString() {
private void validate(String jdbcUser, String jdbcPassword, long
expireTimeInMs) {
Preconditions.checkArgument(StringUtils.isNotBlank(jdbcUser), "JDBC user
should not be empty");
- Preconditions.checkArgument(
- StringUtils.isNotBlank(jdbcPassword), "JDBC password should not be
empty");
+ Preconditions.checkArgument(jdbcPassword != null, "JDBC password should
not be null");
Review Comment:
JDBC password can be empty string?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
