diqiu50 commented on code in PR #11264:
URL: https://github.com/apache/gravitino/pull/11264#discussion_r3379200721
##########
trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/catalog/glue/GlueConnectorAdapter.java:
##########
@@ -101,6 +91,19 @@ public Map<String, String> buildInternalConnectorConfig(
return config;
}
+ static void applyS3Credential(Credential[] credentials, Map<String, String>
config) {
+ for (Credential credential : credentials) {
+ if (credential instanceof S3SecretKeyCredential) {
+ S3SecretKeyCredential s3 = (S3SecretKeyCredential) credential;
+ config.put(HIVE_METASTORE_GLUE_ACCESS_KEY, s3.accessKeyId());
+ config.put(HIVE_METASTORE_GLUE_SECRET_KEY, s3.secretAccessKey());
+ config.put(HIVE_S3_ACCESS_KEY, s3.accessKeyId());
+ config.put(HIVE_S3_SECRET_KEY, s3.secretAccessKey());
+ return;
Review Comment:
Glue is typically used on AWS, so it generally works with S3. Other
requirements can be support as needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
