LauraXia123 commented on code in PR #11812:
URL: https://github.com/apache/gravitino/pull/11812#discussion_r3504012506
##########
web/web/src/lib/auth/providers/factory.js:
##########
@@ -65,6 +65,18 @@ class OAuthProviderFactory {
}
const config = await response.json()
+ const authenticators = config['gravitino.authenticators'] || []
+
+ // Authenticator logic
+ if
(authenticators.includes('org.apache.gravitino.idp.auth.BasicAuthenticator')) {
+ // If BasicAuthenticator is present, set provider type to 'basic' and
do not initialize any OAuth provider
+ this.providerType = 'basic'
+ this.currentProvider = null
+
+ return null
+ }
Review Comment:
This file handles OAuth. Why is Basic authentication logic added here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
