Octavi00 commented on PR #11812: URL: https://github.com/apache/gravitino/pull/11812#issuecomment-4941977875
Hi @LauraXia123, I've spent some time adapting my V1 changes into the V2 web, and it actually turned out to be a pretty smooth process. I used an ant design in my BasicLoginPage.js to avoid making an unnecessary decision, like installing another library in order to reuse my V1 page. I got the ui page to show a proper error message upon failed login attempts, and also included the redirection from root (8090) to homepage (ui/metalakes) as I mentioned in the v1 rendition. I avoided some unnecessary changes for v2, and I included the decoupling method you were looking for in the login/page.js. I separated auth from oidcs or default into being derived based on authType, as well as providerType if it's Oauth. Also, would you like me to rename the default variable to something like defaultOAuth? Apart from that, all changes are very similar, and I would like to request a copilot review, as was done previously, to help make sure I'm not overlooking something. Thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
