yuqi1129 commented on code in PR #11916:
URL: https://github.com/apache/gravitino/pull/11916#discussion_r3536123064
##########
catalogs-contrib/catalog-jdbc-clickhouse/src/main/java/org/apache/gravitino/catalog/clickhouse/operations/ClickHouseTableOperations.java:
##########
@@ -479,23 +480,21 @@ private void appendIndexesSql(Index[] indexes,
StringBuilder sqlBuilder) {
sqlBuilder.append(" PRIMARY KEY (").append(fieldStr).append(")");
break;
case DATA_SKIPPING_MINMAX:
- Preconditions.checkArgument(
- StringUtils.isNotBlank(index.name()), "Data skipping index name
must not be blank");
- // The GRANULARITY value is always 1 here currently as we can't set
it by Index: there is
Review Comment:
Comment like `The GRANULARITY value is always 1 here currently as we can't
set it by Index` needs to be kept until we have already support it.
##########
api/src/main/java/org/apache/gravitino/rel/indexes/Index.java:
##########
@@ -122,12 +122,14 @@ enum IndexType {
/** IVF_HNSW_PQ */
IVF_HNSW_PQ,
- // The following index types are data skipping indexes in ClickHouse,
ngrambf_v1 and tokenbf_v1
Review Comment:
Skip indexes like ngrambf_v1 and tokenbf_v1 still not supported, we'd better
not remove the comment here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
