jiangxt2 commented on PR #11916: URL: https://github.com/apache/gravitino/pull/11916#issuecomment-4904907454
Thanks for the thorough review! Ive addressed all comments in `ea1d1aa`: 1. **Comment on `Index.java`** — Restored the note about `ngrambf_v1` and `tokenbf_v1` not yet supported. These require a parameter-passing mechanism (unlike `set`), so the comment is still relevant. 2. **Comment on `appendIndexesSql`** — Restored the GRANULARITY explanation comments for `minmax` (always 1) and `bloom_filter` (always 3), as the `Index` API doesnt support custom GRANULARITY yet. 3. **Double "INDEX" bug in `addIndexDefinition`** — Good catch by Copilot! The refactored code was producing `"ADD INDEX INDEX ..."` because `buildDataSkippingIndexDdl()` already includes the leading `INDEX` keyword. Fixed by changing `"ADD INDEX "` to `"ADD "`. All tests pass: unit tests (25) + Docker IT — CatalogClickHouseIT (31) + CatalogClickHouseClusterIT (12), including the `testAlterIndexAndAutoIncrementBranches` and `testAlterAddIndexAndAutoIncrementInCluster` tests that exercise the ALTER TABLE ADD INDEX path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
