jarredhj0214 commented on PR #11906: URL: https://github.com/apache/gravitino/pull/11906#issuecomment-4910771310
> > > @roryqi Should the "bulk" scenario also consider the scenario where "externalId" is used as the association key? > > > > > > I think yes. > > @jarredhj0214 Coluld you split PR? In addition, the implementation of the externalID scenario needs to be considered. Currently, the existing single user/group/role access-control APIs are name-based and do not support `externalId` as the association key. This PR follows the current single-operation API contract and keeps the bulk APIs name-based as well. If we want to support `externalId`, I think it should be discussed as a separate API/model design because it may require changes to the user/group identity model, request DTOs, storage lookup, and OpenAPI contract, not only the bulk APIs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
