jarredhj0214 commented on PR #11906: URL: https://github.com/apache/gravitino/pull/11906#issuecomment-4911073719
> > > @jarredhj0214 can you split into several small PRs? The current PR is too large to review. > > > > > > I have split the original large PR into smaller PRs. > > The first split PR will include bulk user operations and the common bulk infrastructure. The bulk group and bulk role operations will be submitted as follow-up PRs after the first one is reviewed/merged, so each PR remains easier to review. > > For the `externalId` point: the existing single user/group/role access-control APIs are name-based and do not support `externalId` as the association key. The split PRs will stay aligned with the current name-based API contract. I think `externalId` support may require a separate API/model design and can be discussed as a follow-up. > > You can update the code. The externalId method has already been implemented. I have updated this PR based on the latest `externalId` and `enabled` support. Bulk user add now uses `UserAddRequest[]`, so it supports `name`, `externalId`, and `enabled`, consistent with the single user add API. The OpenAPI docs, access-control docs, examples, and tests have also been updated. The bulk remove API remains name-based, aligned with the existing single delete user API. The latest changes have been pushed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
