roryqi commented on code in PR #11959:
URL: https://github.com/apache/gravitino/pull/11959#discussion_r3567816198


##########
catalogs/catalog-lakehouse-iceberg/src/main/java/org/apache/gravitino/catalog/lakehouse/iceberg/IcebergCatalog.java:
##########
@@ -68,6 +68,22 @@ public ViewCatalog asViewCatalog() {
     return (ViewCatalog) ops();
   }
 
+  @Override
+  public boolean shouldValidateConnectionForCreate() {

Review Comment:
   Yes, it should throw an exception if the parameter is error.
   We should consider the case which the remote catalog is temporarily down. 
Users will expect federated down won't influence the other.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to