nevzheng commented on code in PR #11959:
URL: https://github.com/apache/gravitino/pull/11959#discussion_r3605044756
##########
catalogs/catalog-lakehouse-iceberg/src/main/java/org/apache/gravitino/catalog/lakehouse/iceberg/IcebergCatalog.java:
##########
@@ -68,6 +68,22 @@ public ViewCatalog asViewCatalog() {
return (ViewCatalog) ops();
}
+ @Override
+ public boolean shouldValidateConnectionForCreate() {
Review Comment:
Following up with the implemented behavior: I separated invalid
configuration from downstream dependency failures.
- An invalid REST `warehouse` selector returns HTTP 400.
- An unreachable backend or HTTP 503 returns `ConnectionFailedException` /
HTTP 502.
- With a nonblank `warehouse`, an outage fails creation cleanly and nothing
is persisted.
- Without `warehouse`, creation remains allowed and the dependency failure
is reported when the catalog is first used.
This is covered by `testCreateRestCatalogWithUnreachableServerAtCreate`,
`testOperationOnUnreachableRestCatalogFailsWithConnectionError`, and
`testHandleRestExceptionTranslatesUnavailableToConnectionFailed`.
This resolves the configuration-versus-dependency distinction. Since you
subsequently said LGTM, I’m marking the thread resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
