JoegenUSTC commented on code in PR #11846:
URL: https://github.com/apache/gravitino/pull/11846#discussion_r3569304977
##########
catalogs/catalog-glue/src/main/java/org/apache/gravitino/catalog/glue/GlueCatalogCapability.java:
##########
@@ -62,18 +62,15 @@ public CapabilityResult columnDefaultValue() {
@Override
public CapabilityResult caseSensitiveOnName(Scope scope) {
- switch (scope) {
- case SCHEMA:
- case TABLE:
- // Glue folds database/table names to lowercase on storage.
- // See
https://docs.aws.amazon.com/glue/latest/dg/aws-glue-api-catalog-databases.html
- // See
https://docs.aws.amazon.com/glue/latest/dg/aws-glue-api-catalog-tables.html
- return CapabilityResult.unsupported(
- "AWS Glue Data Catalog is case-insensitive for "
- + scope.name().toLowerCase(Locale.ROOT)
- + " names.");
- default:
- return CapabilityResult.SUPPORTED;
+ if (scope == Scope.SCHEMA || scope == Scope.TABLE) {
+ // Glue folds database/table names to lowercase on storage.
+ // See
https://docs.aws.amazon.com/glue/latest/dg/aws-glue-api-catalog-databases.html
+ // See
https://docs.aws.amazon.com/glue/latest/dg/aws-glue-api-catalog-tables.html
Review Comment:
Added Preconditions.checkArgument(scope != null, "scope cannot be null") at
the top of the method, matching the existing guard in HiveCatalogCapability. A
new unit test testCaseSensitiveOnNameRejectsNullScope verifies the
IllegalArgumentException is thrown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
