JoegenUSTC commented on PR #11846:
URL: https://github.com/apache/gravitino/pull/11846#issuecomment-4956234001
> @JoegenUSTC It's better not to use force-push as I can't figure out the
changes you made in the latest commit, and then I can't know whether the
comments have been resolved or not easily.
@yuqi1129
直接回复 yuqi，复制粘贴用：
---
Sorry for the force-push! Noted — I'll use regular commits going forward so
the review history stays readable.
Here's a summary of what changed in the latest push to make it easy to
review:
1. **`GlueCatalogCapability.caseSensitiveOnName`** — added
`Preconditions.checkArgument(scope != null, "scope cannot be null")` to guard
against null input (mirrors the existing guard in `HiveCatalogCapability`).
2. **`TestGlueCatalogCapability`** — added
`testCaseSensitiveOnNameRejectsNullScope` to cover the new null guard.
3. **`TestCatalogWrapperConcurrency`** — three small test quality fixes:
- Replaced `Thread.sleep(100)` with a bounded `Thread.yield()` spin-wait
to avoid time-sensitive flakiness.
- Added assertion on `ready.await()` return value.
- Moved `exec.shutdownNow()` into a `finally` block.
- Replaced FQN `org.apache.gravitino.utils.ThrowableFunction` with a
proper import.
No logic changes to production code other than the null guard in Glue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
