LauraXia123 commented on code in PR #11812:
URL: https://github.com/apache/gravitino/pull/11812#discussion_r3577351133
##########
web-v2/web/src/app/login/page.js:
##########
@@ -94,7 +99,15 @@ const LoginContent = () => {
/>
)}
- {useOidcLogin ? <OidcLogin /> : <DefaultLogin />}
+ {authType === null ? null : authType === 'basic' ? (
+ <BasicLogin />
+ ) : authType === 'simple' ? (
+ <DefaultLogin />
+ ) : authType === 'oauth' && providerType === null ? null : authType
=== 'oauth' && providerType === 'oidc' ? (
+ <OidcLogin />
+ ) : authType === 'oauth' ? (
+ <DefaultLogin />
+ ) : null}
Review Comment:
I suggest splitting the simple login form and the OAuth login form within
the DefaultLogin component into two separate components, so that loading
components based on authType becomes clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
