LauraXia123 commented on code in PR #11812:
URL: https://github.com/apache/gravitino/pull/11812#discussion_r3577460011
##########
web-v2/web/src/lib/store/auth/index.js:
##########
@@ -175,6 +209,11 @@ export const logoutAction = createAsyncThunk(
)
export const setIntervalIdAction =
createAsyncThunk('auth/setIntervalIdAction', async (expiredIn, { dispatch }) =>
{
+ // If the auth type is basic, we don't need to set an interval for token
refresh
+ if (localStorage.getItem('authType') === 'basic') {
+ return { intervalId: null }
+ }
+
Review Comment:
setIntervalIdAction is never called for basic auth — the guard is
unreachable dead code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
