yuqi1129 commented on code in PR #12015:
URL: https://github.com/apache/gravitino/pull/12015#discussion_r3585369281
##########
core/src/main/java/org/apache/gravitino/utils/IsolatedClassLoader.java:
##########
@@ -172,8 +172,10 @@ protected Class<?> loadClass(String name, boolean resolve)
throws ClassNotFoundE
try {
return clazz == null ? doLoadClass(name, resolve) : clazz;
+ } catch (ClassNotFoundException e) {
+ throw e;
Review Comment:
Can you add some comments here about why we need to treat
`ClassNotFoundException` differently? Then users can get more details when
they review the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
