yuqi1129 commented on PR #12015: URL: https://github.com/apache/gravitino/pull/12015#issuecomment-4978080046
> Yes, I verified it with a Paimon 1.4.1 codegen path close to the original failure. > > The verification loads `paimon-bundle-1.4.1.jar` through two isolated `URLClassLoader` variants and triggers the same codegen path: > > * `UserDefinedSeqComparator.create(...)` > * `CodeGenUtils.newRecordComparator(...)` > * `GeneratedClass.compile(CodeGenUtils.class.getClassLoader())` > * Paimon's shaded Janino compile > > With the old behavior, where class loading misses are wrapped into a caused `ClassNotFoundException`, the compile fails with `ClassNotFoundException: Override`. > > With the updated behavior, where plain `ClassNotFoundException` is preserved for probe misses, the same Paimon 1.4.1 codegen path succeeds and returns a `UserDefinedSeqComparator`. > > So this change fixes the Janino probing behavior needed by the Paimon 1.4.1 codegen path. Okay. LGTM except a minor one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
