diqiu50 commented on code in PR #12121:
URL: https://github.com/apache/gravitino/pull/12121#discussion_r3628717853
##########
flink-connector/flink-common/src/main/java/org/apache/gravitino/flink/connector/paimon/GravitinoPaimonCatalog.java:
##########
@@ -129,43 +134,75 @@ public void open() throws CatalogException {
super.open();
return;
}
+ Map<String, String> paimonOptions = new HashMap<>(mutableOptions);
+ Configuration hadoopConf =
+
HadoopUtils.getHadoopConfiguration(Options.fromMap(withoutHadoopOptions(paimonOptions)));
+ moveHadoopOptionsToConf(paimonOptions, hadoopConf);
try {
CredentialPropertyUtils.applyPaimonCredentials(
- CredentialPropertyUtils.getCredentials(catalog()), mutableOptions);
Review Comment:
`CredentialPropertyUtils.applyPaimonCredentials` may put credentials to
mutableOptions.
We need to confirm one thing: should these properties be removed from
`paimonOptions`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
