lasdf1234 commented on PR #12121:
URL: https://github.com/apache/gravitino/pull/12121#issuecomment-5086874331
1、Would these three
methods(toHadoopConfKey、withoutHadoopOptions、moveHadoopOptionsToConf) be more
suitable to be placed in PropertyUtils?
2、withoutHadoopOptions + moveHadoopOptionsToConf may be can mrege into one
method better:
static Configuration extractHadoopConfiguration(Map<String, String> options)
{
Map<String, String> hadoopProps = new HashMap<>();
options.entrySet().removeIf(e -> {
String hadoopKey = toHadoopConfKey(e.getKey()); // private
if (hadoopKey == null) return false;
hadoopProps.put(hadoopKey, e.getValue());
return true;
});
Configuration conf =
HadoopUtils.getHadoopConfiguration(Options.fromMap(options));
hadoopProps.forEach(conf::set);
return conf;
}
Make toHadoopConfKey become a private method in PropertyUtils.
3、May be method applyCredentialsToCatalog move into CredentialPropertyUtils
better?
@jarredhj0214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
