nevzheng commented on PR #10975: URL: https://github.com/apache/gravitino/pull/10975#issuecomment-5092953413
Hi @Octavi00 — thanks for checking in. The goal is an integration-style test of the **client → server** path with the correct TLS configuration: `HTTPClient.withTlsConfigurer` / `configureHttp(...)` talking to a TLS-enabled server, covering the success and failure cases from the earlier matrix. Focus on getting that working first; we can review the specifics afterward. To unblock your two questions: 1. **New test file** — yes, please add a dedicated file such as `TestHTTPClientTLS.java` under `clients/client-java/src/test/java/org/apache/gravitino/client/` rather than growing `TestHTTPClient`. That keeps the TLS CUJs easy to find and maintain. 2. **Certificate fixtures** — copy the PKCS12 fixtures into `clients/client-java/src/test/resources/tls/` (same layout as `server-common`). Duplication is fine for small test-only stores. Please don’t invent a repo-global shared path for this. `client-java` already depends on `server-common` for tests, so you can start a Jetty HTTPS server from the client module and point the Gravitino HTTP client at it. You’re empowered to make the remaining local decisions in pursuit of that goal — I trust your judgment. Tag me when you have something ready for another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
