Octavi00 commented on PR #10975: URL: https://github.com/apache/gravitino/pull/10975#issuecomment-5053315091
@nevzheng I have implemented an http injection method as requested, and I wanted to ask if you'd still like to see GravitinoAdminClient and GravitinoClient keep their original constructor and add the new httpConfigurer in another constructor? I had assumed that wouldn't be necessary, as the new parameter httpConfigurer is optional, but I still kept the original constructor for GravitinoClientBase since I feel that it's already in use by other subclasses, and there may be a large change if I were to force all bases to be constructed with the new parameter. My second question is about testing. Would you want me to create some new pkcs12 certs and drop them in the resources folder within the Jetty server test folder? To me, this seems reasonable as long as I include "test" within their individual names, and that way they can be reused elsewhere if needed in the future. Otherwise, I think the second option would be to create them at runtime and delete them afterwards, but that seems like a spot for failure and would just be more code to execute during tests? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
