roryqi commented on code in PR #11739: URL: https://github.com/apache/gravitino/pull/11739#discussion_r3664124130
########## core/src/main/java/org/apache/gravitino/storage/relational/EntityChangeLogCleaner.java: ########## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.storage.relational; + +import com.google.common.annotations.VisibleForTesting; +import com.google.common.base.Preconditions; +import java.util.concurrent.Executors; +import java.util.concurrent.ScheduledExecutorService; +import java.util.concurrent.ThreadLocalRandom; +import java.util.concurrent.TimeUnit; +import org.apache.gravitino.storage.relational.mapper.EntityChangeLogMapper; +import org.apache.gravitino.storage.relational.utils.SessionUtils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Periodically removes expired rows from {@code entity_change_log} on a dedicated thread. Review Comment: If we use unreasonable parameter, it may cause the changes lost Could u add the parameter for the similar cases? ########## core/src/main/java/org/apache/gravitino/storage/relational/mapper/provider/postgresql/EntityChangeLogPostgreSQLProvider.java: ########## @@ -26,6 +27,13 @@ public class EntityChangeLogPostgreSQLProvider extends EntityChangeLogBaseSQLProvider { + /** + * PostgreSQL flavour of the DB-side "now in milliseconds" expression. Insertion and expiration + * share it, so retention is measured entirely with the database clock. + */ + private static final String CURRENT_TIME_MILLIS_SQL = Review Comment: It would better to put it a better place. Other class can reuse this constant easily. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
