yuqi1129 commented on code in PR #11739: URL: https://github.com/apache/gravitino/pull/11739#discussion_r3664486349
########## core/src/main/java/org/apache/gravitino/storage/relational/EntityChangeLogCleaner.java: ########## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.storage.relational; + +import com.google.common.annotations.VisibleForTesting; +import com.google.common.base.Preconditions; +import java.util.concurrent.Executors; +import java.util.concurrent.ScheduledExecutorService; +import java.util.concurrent.ThreadLocalRandom; +import java.util.concurrent.TimeUnit; +import org.apache.gravitino.storage.relational.mapper.EntityChangeLogMapper; +import org.apache.gravitino.storage.relational.utils.SessionUtils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Periodically removes expired rows from {@code entity_change_log} on a dedicated thread. Review Comment: Agreed, that failure mode is silent, which makes it worse. `EntityChangeLogCleaner` now takes the poll interval and validates the retention against it at startup: ``` retentionMs == 0 (cleanup disabled), or retentionMs >= 10 * pollIntervalMs ``` Anything shorter throws `IllegalArgumentException` during initialization instead of silently pruning records before every node consumed them. The bound is 10 poll cycles because a record has to outlive more than a single cycle: a node can miss cycles while restarting, during a long GC pause, or while the poller is paused retrying a failed listener. The comparison uses division rather than multiplication so a large configured poll interval cannot overflow. Covered by `TestEntityChangeLogCleaner#testRejectsRetentionShorterThanTheConsumptionWindow`, and the constraint is documented for `gravitino.entityChangeLog.retentionSecs` in `docs/gravitino-server-config.md`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
