lasdf1234 commented on code in PR #12168:
URL: https://github.com/apache/gravitino/pull/12168#discussion_r3682223767


##########
api/src/main/java/org/apache/gravitino/exceptions/OptimisticLockException.java:
##########
@@ -16,35 +16,37 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-package org.apache.gravitino.encryption.kms;
+package org.apache.gravitino.exceptions;
 
 import com.google.errorprone.annotations.FormatMethod;
 import com.google.errorprone.annotations.FormatString;
-import org.apache.gravitino.exceptions.ConnectionFailedException;
 
-/** Indicates that a KMS backend rejected or could not resolve configured 
credentials. */
-public class KmsAuthenticationException extends ConnectionFailedException {
+/**
+ * Exception thrown when an optimistic-lock update fails because the entity 
changed after it was
+ * read.
+ */
+public class OptimisticLockException extends GravitinoRuntimeException {
 

Review Comment:
   Adding this class is merely to better reflect errors or to avoid certain 
issues? So, if it's an error of this kind, are there any further steps to take?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to