roryqi commented on PR #12168: URL: https://github.com/apache/gravitino/pull/12168#issuecomment-5131405731
> > The structure of storage isn't good. It is oriented process programming. We can't define interface to extract common code. There are fragiled and duplicated code. It would better that we can have object hierarchy layer. Now they are tool classes and we lacked constraints. > > I think it would be better to have some interfaces at least. We shouldn't be stuck in the old design. > > This should be another problem. `EntityStore` is designed for key-value storage specifically originally. The current JDBC entity store was introduced later, but the interface has not been adjusted accordingly. > > I'm not entirely sure whether we should do this refactor in this release. @roryqi do you have such a plan? We can define some interfaces first. We don't need to refactor totally now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
