roryqi commented on PR #12389: URL: https://github.com/apache/gravitino/pull/12389#issuecomment-5248796278
Thanks for the explanation. I do not think accepting the binary fixtures is the right direction here. This repo is maintained collaboratively by many people, so test assets should be reviewable and maintainable by future contributors, not only by the original author. For certificates/truststores, the important part is not just whether the current files work, but whether future reviewers can understand and verify how they were produced and what changed when they are regenerated. I am fine with using the JDK `keytool` approach to avoid adding dependencies. The test setup can generate the required keystores/truststores from text/config inputs, ideally once per test run or reused through a helper/temp directory to avoid unnecessary overhead. So my preference is: 1. Do not commit the binary keystore/truststore fixtures. 2. Keep the generation source/script/config in the repo. 3. Generate the binary artifacts during test setup using JDK tooling. Could you please try the `keytool` approach? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
