roryqi commented on PR #12389: URL: https://github.com/apache/gravitino/pull/12389#issuecomment-5262104329
OK, thanks for the recommendation. Since you are shepherding this issue, I will respect your judgment as much as possible. In general, I prefer to make a PR as complete as reasonably possible, especially because community contributors may not always be able to follow up later. That said, I still think my concern about committing binary test fixtures is valid from a long-term maintainability and reviewability perspective. However, to avoid blocking this work and to let you move it forward in the way you think is most practical, I am willing to compromise on this point for this PR. Let's merge this PR as-is, but we should optimize this in a follow-up PR by generating the keystore/truststore artifacts from reviewable source/configuration instead of committing the generated binaries. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
