yuqi1129 commented on PR #12383: URL: https://github.com/apache/gravitino/pull/12383#issuecomment-5249812821
> Hi @FANNG1 @yuqi1129 , would it be acceptable to simplify the AddColumn implementation by following the existing Lance alter-table flow? > > The proposed flow is: > > 1. Load the table and hydrate the Lance schema if necessary. > 2. Add columns through `Dataset.addColumns`. > 3. Reuse `super.alterTable` to update the Gravitino columns and `lance.version`. > > This would remove the custom metadata CAS and physical rollback logic, and would provide the same best-effort consistency model as the existing DeleteColumn/RenameColumn paths. > > Would this simpler approach be acceptable for the first-phase AddColumn support? It's fine currently. In fact, we need to review the Lance directory as the single source of truth; no matter how much effort we put in, there is still a high possibility that the data in Gravitino and Lance differ. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
