FANNG1 commented on PR #12383: URL: https://github.com/apache/gravitino/pull/12383#issuecomment-5250417296
+1 to reusing the existing Lance `alterTable` flow for the first-phase `AddColumn` support. One architectural concern remains: `super.alterTable` applies the requested changes incrementally to the Gravitino metadata, so it may still produce a Gravitino schema that differs from the schema actually committed by Lance, especially when the two sides have already drifted or Lance normalizes the resulting schema. Since the Lance dataset is the source of truth, replacing or reconciling the Gravitino schema from the actual underlying dataset after the physical change may be more robust. I think that broader reconciliation change can be handled in a separate PR to keep this one focused. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
