roryqi commented on code in PR #12366: URL: https://github.com/apache/gravitino/pull/12366#discussion_r3756074120
########## api/src/main/java/org/apache/gravitino/secret/SecretMaterial.java: ########## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.secret; + +import com.google.common.base.Preconditions; +import java.util.Objects; +import org.apache.gravitino.annotation.Evolving; + +/** + * Write-through secret material: the target {@link SecretUrn} paired with the plaintext to store. + * + * <p>Produced by {@code SecretManager#assembleSecretUrns} and consumed by {@code + * SecretManager#writeSecrets} / {@code SecretManager#rollbackSecrets}. + */ +@Evolving +public final class SecretMaterial { + + private final SecretUrn urn; + private final String plaintext; + + /** + * Creates secret material for a write-through secret. + * + * @param urn write-through URN (provider + entity locator) + * @param plaintext plaintext secret to write + */ + public SecretMaterial(SecretUrn urn, String plaintext) { Review Comment: For the secret references, you don't have the plaintext, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
