roryqi commented on code in PR #12366:
URL: https://github.com/apache/gravitino/pull/12366#discussion_r3756177568
##########
core/src/main/java/org/apache/gravitino/secret/SecretManager.java:
##########
@@ -105,21 +204,23 @@ public List<SecretUrn> getSecretReferenceUrns(Map<String,
SecretReference> secre
/**
* Builds write-through URNs from {@code secretBindings} without writing
secret material.
*
- * <p>Callers should pass the returned URNs to {@link #writeSecrets} to
persist plaintext from
- * each binding's value, then put URNs into properties (e.g. via {@link
- * SecretPropertyUtils#applySecretUrns}).
+ * <p>Callers typically pass the returned URNs to {@link #writeSecrets} via
{@link
+ * #assembleSecretUrns}, or put URN strings into properties themselves (e.g.
via {@link
+ * SecretPropertyUtils#putSecretUrns}).
*
* @param entityType {@code catalog}, {@code schema}, or {@code fileset}
* @param entityId stable numeric entity id
- * @param secretBindings property key → write-through binding
+ * @param secretBindings property key → write-through binding (empty returns
an empty list; must
+ * not be null)
* @return write-through URNs (insertion order)
*/
public List<SecretUrn> getSecretBindingUrns(
Review Comment:
buildSecretMaterials
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
