jiangxt2 commented on code in PR #12274:
URL: https://github.com/apache/gravitino/pull/12274#discussion_r3793542041
##########
catalogs-contrib/catalog-jdbc-clickhouse/src/main/java/org/apache/gravitino/catalog/clickhouse/operations/ClickHouseTableOperations.java:
##########
@@ -458,7 +458,12 @@ private ClickHouseTablePropertiesMetadata.ENGINE
appendTableEngine(
return engine;
}
- sqlBuilder.append("\n ENGINE = %s".formatted(engine.getValue()));
+ String engineParams =
StringUtils.trim(properties.get(TableConstants.ENGINE_PARAMETERS));
Review Comment:
Fixed in follow-up commit 7517295a. Graphite now uses only graphite.config;
generic engine_parameters extraction excludes Graphite. Load and CREATE use
symmetric SQL-literal escaping, with a round-trip unit test added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
