jiangxt2 commented on code in PR #12274:
URL: https://github.com/apache/gravitino/pull/12274#discussion_r3793549843
##########
catalogs-contrib/catalog-jdbc-clickhouse/src/main/java/org/apache/gravitino/catalog/clickhouse/operations/ClickHouseTableOperations.java:
##########
@@ -705,6 +710,20 @@ protected Map<String, String>
getTableProperties(Connection connection, String t
put(ClusterConstants.ON_CLUSTER, String.valueOf(false));
}
+ // Extract engine parameters from engine_full for
non-Distributed engines.
+ // engine_full contains the full engine DDL (e.g.
+ // "ReplacingMergeTree(ts) ORDER BY id SETTINGS ..."),
while the engine
+ // column only contains the engine name without parameters.
+ // For Distributed engines, parameters are already stored
as separate
+ // distributed-table properties below.
+ if (!StringUtils.equalsIgnoreCase(engine,
ENGINE.DISTRIBUTED.getValue())) {
Review Comment:
Fixed in 7517295a. LOAD and CREATE now share an allowlist of four supported
MergeTree engines. Graphite and Distributed use dedicated properties, while
other engines neither expose nor accept engine_parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
