jerryshao commented on code in PR #12522:
URL: https://github.com/apache/gravitino/pull/12522#discussion_r3820137310
##########
docs/open-api/jobs.yaml:
##########
Review Comment:
Good catch — fixed the enum to "cancelled" to match the actual wire format
(JobDTO's StatusSerializer emits
JobHandle.Status.CANCELLED.name().toLowerCase() = "cancelled") and the
statusCounts example at L1027.
##########
server/src/main/java/org/apache/gravitino/server/web/rest/JobOperations.java:
##########
@@ -285,13 +291,31 @@ public Response alterJobTemplate(
public Response listJobs(
@PathParam("metalake") @AuthorizationMetadata(type =
Entity.EntityType.METALAKE)
String metalake,
- @QueryParam("jobTemplateName") String jobTemplateName) {
+ @QueryParam("jobTemplateName") String jobTemplateName,
+ @QueryParam("queuedAfter") String queuedAfter,
Review Comment:
I tried this (a JobListQueryParams bean with @BeanParam, validated in one
place), but on reflection decided to hold off - it would introduce the first
@BeanParam usage in this codebase for a fairly small parameter count (5
fields), and I don't think the cohesion win outweighs that new pattern + the
larger diff right now. Happy to revisit if the endpoint grows more query params
later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
