jerryshao commented on code in PR #12522:
URL: https://github.com/apache/gravitino/pull/12522#discussion_r3820454383
##########
server/src/main/java/org/apache/gravitino/server/web/rest/JobOperations.java:
##########
@@ -285,13 +291,31 @@ public Response alterJobTemplate(
public Response listJobs(
@PathParam("metalake") @AuthorizationMetadata(type =
Entity.EntityType.METALAKE)
String metalake,
- @QueryParam("jobTemplateName") String jobTemplateName) {
+ @QueryParam("jobTemplateName") String jobTemplateName,
+ @QueryParam("queuedAfter") String queuedAfter,
+ @QueryParam("startedAfter") String startedAfter,
+ @QueryParam("finishedAfter") String finishedAfter,
+ @QueryParam("sortBy") @DefaultValue("queuedAt") String sortBy,
+ @QueryParam("sortOrder") @DefaultValue("desc") String sortOrder) {
Review Comment:
Both addressed:
- Blank `sortBy`/`sortOrder`/`queuedAfter`/`startedAfter`/`finishedAfter`
are now treated as "not set" rather than falling through to
`default:`/`Instant.parse("")`. Added a test covering
`?sortBy=&sortOrder=&queuedAfter=`.
- Left `statusCounts` counting the post-filter set (matches the spec text
"The number of jobs in \"jobs\""), but called out the structural-zero behavior
explicitly in the spec description so it's not surprising in a UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
