jerryshao commented on code in PR #12499: URL: https://github.com/apache/gravitino/pull/12499#discussion_r3829714172
########## api/src/main/java/org/apache/gravitino/semantic/Dimension.java: ########## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.semantic; + +import java.util.Objects; +import javax.annotation.Nullable; +import org.apache.gravitino.annotation.Evolving; + +/** Metadata that identifies a Semantic Model field as a dimension. */ +@Evolving +public final class Dimension { Review Comment: **Simplification: full value class just to wrap one nullable Boolean** `Dimension` (private field, Builder, equals/hashCode/toString, javadoc — 121 lines) exists solely to carry a single `@Nullable Boolean isTime`. `Field` holds it as `@Nullable private final Dimension dimension` with nothing else attached. Consider exposing `@Nullable Boolean isTime()` / `withIsTime(...)` directly on `Field` instead of the extra indirection layer, unless more dimension-related fields are already planned to land here soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
