mchades commented on code in PR #12499: URL: https://github.com/apache/gravitino/pull/12499#discussion_r3831315899
########## api/src/main/java/org/apache/gravitino/semantic/SemanticModelDefinition.java: ########## @@ -0,0 +1,265 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.semantic; + +import com.google.common.base.Preconditions; +import java.util.Arrays; +import java.util.Objects; +import javax.annotation.Nullable; +import org.apache.gravitino.annotation.Evolving; + +/** + * An immutable Semantic Model definition. This value groups the Ossie-compatible definition fields + * used when creating or replacing a Semantic Model and has no name or independent lifecycle. + */ +@Evolving +public final class SemanticModelDefinition { Review Comment: I agree. I’ll update `SemanticModel` to expose a `SemanticModelDefinition definition()` and remove the duplicated definition-field accessors. This keeps the managed entity metadata on `SemanticModel` while centralizing the immutable definition contract in `SemanticModelDefinition`. I’ll update the tests and design documentation accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
