jerryshao commented on code in PR #12553:
URL: https://github.com/apache/gravitino/pull/12553#discussion_r3840659391


##########
core/src/main/java/org/apache/gravitino/listener/CatalogEventDispatcher.java:
##########
@@ -199,10 +199,16 @@ public void testConnection(
       String comment,
       Map<String, String> properties)
       throws Exception {
-    // TODO: Support event dispatching for testConnection
+    // TODO(#12566): Support event dispatching for testConnection
     dispatcher.testConnection(ident, type, provider, comment, properties);
   }
 
+  @Override
+  public void testConnection(NameIdentifier ident) throws Exception {
+    // TODO(#12566): Support event dispatching for testConnection

Review Comment:
   Please work on this for the feature completness.



##########
core/src/main/java/org/apache/gravitino/listener/CatalogEventDispatcher.java:
##########
@@ -199,10 +199,16 @@ public void testConnection(
       String comment,
       Map<String, String> properties)
       throws Exception {
-    // TODO: Support event dispatching for testConnection
+    // TODO(#12566): Support event dispatching for testConnection
     dispatcher.testConnection(ident, type, provider, comment, properties);
   }
 
+  @Override
+  public void testConnection(NameIdentifier ident) throws Exception {
+    // TODO(#12566): Support event dispatching for testConnection

Review Comment:
   Please work on this for the feature completeness.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to