mchades commented on code in PR #12553:
URL: https://github.com/apache/gravitino/pull/12553#discussion_r3840858804
##########
core/src/main/java/org/apache/gravitino/listener/CatalogEventDispatcher.java:
##########
@@ -199,10 +199,16 @@ public void testConnection(
String comment,
Map<String, String> properties)
throws Exception {
- // TODO: Support event dispatching for testConnection
+ // TODO(#12566): Support event dispatching for testConnection
dispatcher.testConnection(ident, type, provider, comment, properties);
}
+ @Override
+ public void testConnection(NameIdentifier ident) throws Exception {
+ // TODO(#12566): Support event dispatching for testConnection
Review Comment:
I was concerned this would make the PR too large, so I opened #12566 to
track it separately. If you prefer to review it as part of this PR, I can
include the changes here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]