roryqi commented on code in PR #12549: URL: https://github.com/apache/gravitino/pull/12549#discussion_r3844269731
########## api/src/main/java/org/apache/gravitino/policy/PolicyTagAssociation.java: ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.policy; + +import java.util.Optional; +import org.apache.gravitino.annotation.Evolving; +import org.apache.gravitino.tag.Tag; + +/** A policy-to-tag association and its optional assignment selector. */ +@Evolving +public interface PolicyTagAssociation { + + /** + * @return The associated policy. + */ + Policy policy(); + + /** + * @return The associated tag. + */ + Tag tag(); + + /** + * @return The selector, or empty when the association matches by tag presence. + */ + Optional<PolicySelector> selector(); Review Comment: No. The selector belongs to a specific policy-to-tag association, not to the policy definition itself. The same policy can be associated with different tags using different selectors. To make this ownership explicit, I renamed `PolicySelector` to `PolicyAssociationSelector`. The concrete selector implementations are now `AllValuesSelector` and `TagValueSelector`. ########## api/src/main/java/org/apache/gravitino/tag/TagOperations.java: ########## @@ -115,4 +117,64 @@ Tag alterTag(String name, TagChange... changes) * @return True if the tag is deleted, false if the tag does not exist. */ boolean deleteTag(String name); + + /** + * Lists policy names directly associated with a tag. + * + * @param tagName The tag name. + * @return The directly associated policy names. + * @throws UnsupportedOperationException If listing policy-to-tag associations is not supported. + */ + default String[] listPoliciesForTag(String tagName) { + throw new UnsupportedOperationException("Listing policies for a tag is not supported"); + } + + /** + * Lists detailed policy associations for a tag. + * + * @param tagName The tag name. + * @return The policy associations including selectors. + * @throws UnsupportedOperationException If listing policy-to-tag associations is not supported. + */ + default PolicyTagAssociation[] listPolicyAssociationsForTag(String tagName) { + throw new UnsupportedOperationException( + "Listing policy associations for a tag is not supported"); + } + + /** + * Adds or updates one policy association for a tag without a selector. + * + * @param tagName The tag name. + * @param policyName The policy name. + * @return The resulting association. + * @throws UnsupportedOperationException If adding policy-to-tag associations is not supported. + */ + default PolicyTagAssociation addPolicyForTag(String tagName, String policyName) { + throw new UnsupportedOperationException("Adding a policy for a tag is not supported"); + } Review Comment: We no longer represent this behavior with a missing or null selector. Every policy-to-tag association has an explicit selector. `AllValuesSelector` is used for tag-presence matching and matches whenever the effective tag assignment exists, regardless of whether it has no value, one value, or multiple values. The two-argument `addPolicyForTag` overload delegates using `AllValuesSelector`, and `PolicyTagAssociation.selector()` is now non-optional. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
