roryqi commented on code in PR #12549: URL: https://github.com/apache/gravitino/pull/12549#discussion_r3850535446
########## api/src/main/java/org/apache/gravitino/policy/PolicyTagAssociation.java: ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.policy; + +import java.util.Optional; +import org.apache.gravitino.annotation.Evolving; +import org.apache.gravitino.tag.Tag; + +/** A policy-to-tag association and its optional assignment selector. */ +@Evolving +public interface PolicyTagAssociation { + + /** + * @return The associated policy. + */ + Policy policy(); + + /** + * @return The associated tag. + */ + Tag tag(); + + /** + * @return The selector, or empty when the association matches by tag presence. + */ + Optional<PolicySelector> selector(); Review Comment: No, it's stored in the association about policy and tag. ``` CREATE TABLE IF NOT EXISTS policy_tag_relation_meta ( id BIGSERIAL NOT NULL, policy_id BIGINT NOT NULL, tag_id BIGINT NOT NULL, selector TEXT DEFAULT NULL, audit_info TEXT NOT NULL, current_version INT NOT NULL DEFAULT 1, last_version INT NOT NULL DEFAULT 1, deleted_at BIGINT NOT NULL DEFAULT 0, PRIMARY KEY (id), UNIQUE (policy_id, tag_id, deleted_at) ); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
