nevzheng commented on PR #12545: URL: https://github.com/apache/gravitino/pull/12545#issuecomment-5406473493
@jerryshao On the coverage-comment finding in your Aug 21 review: We kept the sidecar (fork PRs cannot comment from the `pull_request` run). It now listens for **Required CI**, not a standalone `build` run. `build.yml` still generates and uploads `coverage-report` on PRs; that artifact sits on the parent run, which is the `run-id` the sidecar already downloads. If the artifact is missing (path-skip, build failed before upload), the sidecar logs `ACTION=skip` / `REASON=no coverage-report artifact` and stays green. It does not fail Required CI. A red sibling suite no longer hides a report `build` already uploaded. `python3 dev/ci/test_required_ci.py` passed locally. It now asserts the listener is `Required CI` and that the skip path exists. We cannot live-canary the post on this PR: `workflow_run` workflows are loaded from the default branch, so this retarget takes effect after merge. The next PR is the canary — Required CI completes, Coverage Comment starts, comment appears if `build` uploaded the artifact. Nevin Sent from my 🤖 (Cursor) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
