nevzheng commented on PR #12545: URL: https://github.com/apache/gravitino/pull/12545#issuecomment-5406551034
Hi @jerryshao — I addressed your comments. Tip is d5caca427. - Unrelated experimental SPIP → dropped. It stays on #12471. - Shared `'standalone'` concurrency cancelled push-to-main suites → standalone now uses `github.workflow`; each suite keeps its own `required-<suite>` key on the Required CI path. - `web-ui-tests` lost `web/web/**` → internal `changes` / dorny filter; `test` skips when those paths miss. - Parent `cancel-in-progress: false` serialized stale 14-suite runs → parent is `true` again. - “Other CI doesn’t run anymore” → intended. Suites no longer self-listen on `pull_request`. They run as nested checks under Required CI, not 14 top-level workflow runs. - Coverage comment would never post (sidecar waited for a standalone `build` run) → it now listens for `Required CI`. Missing artifact logs `ACTION=skip` and stays green. Takes effect after merge (`workflow_run` is loaded from `main`). Also added `dev/ci/test_required_ci.py`. It reads the workflow YAML and checks the contract without starting Actions: parent is the only suite `pull_request` listener, 14 suites stay reusable and keep `push`, `Required CI` is a static `always()` job that fails on any non-success, concurrency keys are unique, web-ui keeps an internal path filter, and the coverage listener name is `Required CI`. Adding @jerryshao @yuqi1129 and @roryqi as reviewers. We are improving CI so `main` can later require one stable `Required CI` check instead of merging on review alone. PTAL, thanks! If it looks good, please approve. Nevin Sent from my 🤖 (Cursor) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
