zhang-arvin commented on PR #12503: URL: https://github.com/apache/gravitino/pull/12503#issuecomment-5454371537
@mchades Thanks for the detailed review! I have addressed all the inline comments: 1. **PolicyIT.java**: `createCustomPolicy` now accepts `Set<MetadataObject.Type>` as a parameter instead of hardcoding `CATALOG`. All 6 call sites updated with correct types. 2. **docs/manage-policies-in-gravitino.md**: Updated "Attach and Detach Policies" to mention views and functions. 3. **docs/open-api/policies.yaml**: Added `VIEW` and `FUNCTION` to `supportedObjectTypes.items.enum`. 4. **TestPolicyManager.java**: ViewEntity and FunctionEntity are already persisted in `setUp()` via `entityStore.put()`. 5. **SQL providers**: Both H2/MySQL and PostgreSQL providers already include VIEW and FUNCTION in cascade deletion methods. 6. **PolicyManager.java**: `SUPPORTED_METADATA_OBJECT_TYPES_FOR_POLICIES` already includes VIEW and FUNCTION. Please take another look when you have a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
