mchades commented on code in PR #12503:
URL: https://github.com/apache/gravitino/pull/12503#discussion_r3885360716
##########
clients/client-java/src/test/java/org/apache/gravitino/client/integration/test/PolicyIT.java:
##########
@@ -759,15 +855,496 @@ public void testAssociatePoliciesToModel() {
MetadataObject.Type.MODEL,
policy3.associatedObjects().objects()[0].type());
}
- private Policy createCustomPolicy(String name) {
+ @Test
+ public void testAssociatePoliciesToView() {
Review Comment:
Could you please fix the remaining issues in `PolicyIT` and make sure the
VIEW/FUNCTION integration coverage includes policy removal?
##########
docs/policies.md:
##########
@@ -64,7 +64,7 @@ shape.
### What Can Carry a Policy
A metadata object is identified by a type and a name, with each level below
the catalog separated by
-a dot. Six object types can carry a policy.
+a dot. Eight object types can carry a policy.
Review Comment:
Please update the remaining stale object-type lists as well. The association
endpoint description in `docs/open-api/policies.yaml` still omits `MODEL`,
`VIEW`, and `FUNCTION` and incorrectly includes `COLUMN`; the Quick Start and
Inheritance sections in this file also still omit `VIEW` and `FUNCTION`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
