IcebreakerSA opened a new pull request, #12935:
URL: https://github.com/apache/gravitino/pull/12935

   ### What changes were proposed in this pull request?
   
   Normalize table identifiers used by `submit-strategy-jobs`, 
`monitor-metrics`, and `list-table-metrics`. Fully qualified 
`catalog.schema.table` identifiers pass through unchanged, while `schema.table` 
identifiers use `gravitino.optimizer.gravitinoDefaultCatalog`.
   
   Keep job identifier parsing unchanged and add CLI regression tests for all 
affected commands.
   
   ### Why are the changes needed?
   
   The table-oriented commands currently parse identifiers directly, so they 
pass `schema.table` to downstream components even when a default catalog is 
configured. This differs from `submit-update-stats-job` and from the documented 
default-catalog behavior. Without a default catalog, the same input is accepted 
and fails later or is interpreted inconsistently.
   
   Fix: #10394
   
   ### Does this PR introduce _any_ user-facing change?
   
   Table-oriented optimizer commands now accept `schema.table` when 
`gravitino.optimizer.gravitinoDefaultCatalog` is configured and report a clear 
validation error when it is not. Fully qualified table identifiers and job 
identifiers keep their existing behavior. There are no API or configuration 
changes.
   
   ### How was this patch tested?
   
   - Added five CLI regression tests covering default-catalog normalization in 
the three affected table commands, missing-default validation, and unchanged 
job identifier parsing.
   - Verified that four table-command regression tests fail on the original 
implementation while the job-identifier regression test passes.
   - Ran `:maintenance:optimizer:check -PskipTrinoConnector=true -PskipITs 
-PskipDockerTests=true`: 225 tests passed with no failures or errors. Five 
pre-existing environment integration tests were skipped because 
`GRAVITINO_ENV_IT` was not enabled.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to